added option to enable-disable cache #13
Conversation
There was a problem hiding this comment.
I think we want to be descriptive to the user about what this does so we are clear. @nikhilajudiya Can you confirm this just disables purging the Dispatcher in AEM. Otherwise if enabled it purge the cache for each item that has changed every 30 minutes.
My suggestion would be call this "Dispatcher Cache Purge?" as the headline and if we could have a tooltip provide a desccription that if disabled this will not make any calls to the dispatch.
Maybe @JohnM-729 or @vberkel Have an opinion on the language used here as well.
|
Label "Dispatcher Cache Purge" |
|
Like Marks phrasing, go with it. |
|
We were waiting until the installer problem was resolved, and we're fairly sure we identified that problem. Would be ok to merge and release. |
|
Checked with @nikhilajudiya on this and with our changes this will require some retesting. He will take that on. |
type(scope): if this commit is applied, it will...
i.e. fix(login): [more detailed message]
Why was this change made?
Feature request? A bug was found? Doing some refactoring? Let us know why this should be in our codebase.
Links to any relevant tickets, articles, or other resources
closes https://github.com/SchemaApp/SchemaApp/issues/12813
Other Notes
Did you fix any additional issues or do you have special notes for the reviewer? Put them here.
Suggested Test for Reviewer